Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 25, 2025

The documentation contained incorrect .NET version numbers that didn't follow the standard versioning format used throughout the docs. Several metrics were incorrectly labeled with versions like ".NET 8.8.0" and ".NET 9.8.0" instead of the proper ".NET 8.0" and ".NET 9.0" format.

This PR fixes 5 instances of incorrect version numbers:

  • 3 instances of ".NET 8.8.0" corrected to ".NET 8.0"
  • 2 instances of ".NET 9.8.0" corrected to ".NET 9.0"

The affected metrics were:

  • container.cpu.limit.utilization
  • container.cpu.request.utilization
  • container.cpu.time
  • container.memory.limit.utilization
  • container.memory.usage

The corrected versions now align with the standard .NET version format used consistently throughout the documentation (e.g., ".NET 8.0", ".NET 9.0").

Fixes #45089.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/built-in-metrics-diagnostics.md .NET extensions metrics

Copilot AI changed the title [WIP] Correct the Dotnet version mentioned in the documentation Fix incorrect .NET version numbers in built-in-metrics-diagnostics.md Jul 25, 2025
Copilot AI requested a review from gewarren July 25, 2025 18:46
Copilot finished work on behalf of gewarren July 25, 2025 18:46
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @evgenyfedorov2 can you confirm that these were the versions you intended?

@evgenyfedorov2
Copy link
Member

LGTM. @evgenyfedorov2 can you confirm that these were the versions you intended?

Hmm, actually, .NET Extensions is released monthly and the version numbers in documentation reflect the versions numbers when the code was released with .NET Extensions.

I don't know what the policy is, though? If a metric was released with .NET Extensions 9.8.0, can we say it is available with .NET 9.0?

@gewarren
Copy link
Contributor

If a metric was released with .NET Extensions 9.8.0, can we say it is available with .NET 9.0?

Yes, I think so, if these metrics are released as part of the servicing releases. Perhaps we can say .NET 9 (servicing). If they are released via NuGet package, then I think we could just list the first package version they were available in.

@gewarren gewarren marked this pull request as ready for review August 8, 2025 22:43
@gewarren gewarren requested review from a team and tommcdon as code owners August 8, 2025 22:43
@evgenyfedorov2
Copy link
Member

If they are released via NuGet package, then I think we could just list the first package version they were available in.

Yes, they are part of the https://www.nuget.org/packages/Microsoft.Extensions.Diagnostics.ResourceMonitoring Nuget package. So instead of .NET 8.8.0, we can probably say Microsoft.Extensions.Diagnostics.ResourceMonitoring 8.8.0

@gewarren gewarren enabled auto-merge (squash) August 13, 2025 23:25
@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@gewarren gewarren closed this Aug 14, 2025
auto-merge was automatically disabled August 14, 2025 15:07

Pull request was closed

@gewarren gewarren reopened this Aug 14, 2025
@dotnetrepoman dotnetrepoman bot added this to the August 2025 milestone Aug 14, 2025
@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@gewarren gewarren merged commit afde3c8 into main Aug 14, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct the Dotnet version mentioned in the documentation

3 participants